Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows uri #5161

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Windows uri #5161

wants to merge 3 commits into from

Conversation

fishface60
Copy link
Contributor

@fishface60 fishface60 commented Feb 1, 2025

Identify the Bug or Feature request

closes #5144

Description of the Change

This checks-in the main.wix config that jpackage generates to be able to override it, adds config to create registry entries for URI handlers and changes the installer to be system-wide so that it can install the registry entries to HKCR, since they don't work for HKCU.

Possible Drawbacks

Now users need administrator privileges to install MapTool.

Release Notes

  • Added support for rptools-maptool URIs in Windows, this unfortunately means MapTool has to be installed system-wide since URI handler config goes in the system-wide registry.

This change is Reviewable

overrides.wxi can be overridden for some changes
but I don't know of a way to extend the product and feature config
without altering those elements directly.
This adds config to add registry entries for the rptools-maptool URIs.

Unfortunately this only works for the HKCR registry root
and not HKCU so only works for system-wide installs,
so this config is gated behind the system-wide config.
Unforunately URI handlers must be installed system-wide
so to enable this feature MapTool needs to be built as a system app.
@github-actions github-actions bot added the feature Adding functionality that adds value label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: rptools-maptool URIs for Windows clients
1 participant